Remove attempt to use wizard on manage ACLs

[eileenmcnaughton]

Overview

As reported by @christianwach we are currently seeing smarty failures with php3 on the Manage ACLs screen due to it trying to add wizard navigation at the tpl layer - this just removes that on the basis it adds marginal value to a screen that is already up for replacement - also it didn't really seem to be doing what it said on the box - ie the UI seemed the same after I ripped out the code as before....

Before

After

Loads, no wizard header

Technical Details

We should back port to 5.69 as that was where it was reported

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[totten]

I signed up for a bar class, but my style is still empty. I probably studied under the wrong teacher.

(I should've asked this guy for lessons. He's got it showing a title and everything.)

[eileenmcnaughton]

@totten you got shorter ^^

[totten]

@eileenmcnaughton For that hair, it's an even trade.

[eileenmcnaughton]

lol

[totten]

...this just removes that on the basis it adds marginal value to a screen that is already up for replacement - also it didn't really seem to be doing what it said on the box - ie the UI seemed the same after I ripped out the code as before...

I agree. There is a very subtle difference. (The visual effect of the empty/non-functioning wizard was akin to an extraneous <hr/> -- it just appears as a pointless line.) So it's not adding anything. And most pages which hit this file already have replacements in civicrm_admin_ui.