Do not attempt to register string resources for Smarty3+

[eileenmcnaughton]

Overview

It turns out this is not required for Smarty3 & it breaks for Smarty4.

Further, it is the only thing that breaks for Smarty4

Before

If I go to the smarty3 package and upgrade it to Smarty4 the page fails to load with

After

With this change Smarty4 works - as @demeritcowboy points out the code can also go for Smarty 3 "We should probably remove that line for smarty3 too? In smarty3 string resource is "native", in smarty2 it was something civi added that just happened to then be the same as what smarty added."

Technical Details

Comments

It turned out the step from Smarty3 to Smarty4 is actually very small indeed - this is the only thing I have hit
https://smarty-php.github.io/smarty/5.x/upgrading/#upgrading-from-v3-to-v4

We did make the define 'CIVICRM_SMARTY3_AUTOLOAD_PATH' - which suggests perhaps we should add Smarty4 to it's own folder in packages & add a v4 version & when we are ready put that rather than 3 in composer.

It's also possible that the leap to 5 will be sane...it's not stable yet though

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗