Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#4641) ListUnsubscribe - Fix HTTP URL generation on WordPress #29086

Merged
merged 1 commit into from
Jan 25, 2024

Conversation

totten
Copy link
Member

@totten totten commented Jan 25, 2024

Overview

Follow-up to recent #28964. This fixes an issue with generating the unsubscribe URL on WordPress.

Before

If I execute the mailing job via CLI:

cv api -U admin job.process_mailing

Then the resulting email has List-Unsubscribe which points to the WP backend, e.g.

http://wpmaster.127.0.0.1.nip.io:8001/wp-admin/admin.php?page=CiviCRM&q=civicrm%2Fmailing%2Funsubscribe&reset=1&jid=4&qid=25&h=77jhhesmltetm6uk

This URL doesn't actually work for purposes of HTTP One-Click.

After

The resulting email has List-Unsubscribe which points to the WP frontend. Depending on whether clean URL support is active, this can be either:

http://wpmaster.127.0.0.1.nip.io:8001/civicrm/?civiwp=CiviCRM&q=civicrm%2Fmailing%2Funsubscribe&reset=1&jid=3&qid=28&h=o9qdzkepvkuvwkoo

or

http://wpmaster.127.0.0.1.nip.io:8001/civicrm/mailing/unsubscribe/?reset=1&jid=3&qid=28&h=o9qdzkepvkuvwkoo

Either style works for purposes of HTTP One-Click.

Copy link

civibot bot commented Jan 25, 2024

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.70 label Jan 25, 2024
@totten totten changed the title ListUnsubscribe - Fix HTTP URL generation on WordPress (dev/core#4641) ListUnsubscribe - Fix HTTP URL generation on WordPress Jan 25, 2024
@colemanw colemanw merged commit 35684c9 into civicrm:5.70 Jan 25, 2024
3 checks passed
@totten totten deleted the 5.70-unsub-wp branch January 25, 2024 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants