Copy buildAmount back to form to avoid unhelpful sharing #28916
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Copy buildAmount back to form to avoid unhelpful sharing
Before
buildAmount
shared by 2 front end & one back office formAfter
The back office form has it's own copy - some of the now-unnecessary code removed
Technical Details
In general we have managed to achieve a lot of code cleanup by unsharing functions without clear purpose / signature because the code has to pre-wrangle & post-wrangle
Comments