Fix time handling for dd_mon_yy format date strings

[eileenmcnaughton]

Overview

Fix time handling for dd_mon_yy format

Before

dd_mon_yy format drops the time (if present) when processing the date

After

dd_mon_yy format keeps the (if present) time when processing the date

Technical Details

This PR also has the smaller fix in #28845

It also switches the month comparison from strtolower to mb_strtolower. However, that will have no impact until the validation regex is changed - which is in the last PR in this series #28716

Comments

_

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

This function & the following function were only just added. We should make protected & internal unless there is a reason not to so fixing in this PR

[eileenmcnaughton]

CRM_Contact_Import_Parser_ContactTest::testValidateDateData with data set "type_8" ('individual_dates_type8.csv', 8)
September 12, 2008 should have been valid

/home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php:2343
/home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/tests/phpunit/CRM/Contact/Import/Parser/ContactTest.php:1472
/home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/tests/phpunit/CiviTest/CiviUnitTestCase.php:247
/home/homer/buildkit/extern/phpunit9/phpunit9.phar:2307

[colemanw]

Good amount of code comments and unit test coverage.

[eileenmcnaughton]

Thanks @colemanw - there is one last PR in this series... #28716