APIv4 - Hide 'contact_type' from Individual,Organization,Household getFields #28812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
colemanw
force-pushed
the
removeContactTypeField
branch
from
3aaec5a to
93aa901
Compare
This field is irrelevant to these pseudo-entities and shouldn't need to be used at all. Before: Creating a new SearchKit search for Individual includes Contact Type in the default columns. After: Now it doesn't, and the field is completely hidden for all but the Contact entity.
colemanw
force-pushed
the
removeContactTypeField
branch
from
93aa901 to
f8925ce
Compare
colemanw
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Usability improvement for SearchKit involves hiding an irrelevant field from the API metadata.
Before
Creating a new SearchKit search for Individual includes Contact Type in the default columns. This is confusing because the value of that field will never change.
After
The field is completely hidden for all but the Contact entity.
Technical Details
This field is irrelevant to these entities and shouldn't be needed.