dev/core#4872 - Fix APIv4 error when searching contacts with GROUP BY

[colemanw]

Overview

Fixes https://lab.civicrm.org/dev/core/-/issues/4872

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4872

[MegaphoneJon]

Hi Coleman,

I did a r-run and this fixes the bug.

However, in my testing, the variable you're checking if it's a string failed when it was an array that looked like this:

$contactType[''] = ['Organization', 'Individual'];

Is returning an empty array the correct behavior here? See #28739.

If you think this is the correct solution though, then this is merge-on-pass.

[colemanw]

@MegaphoneJon this function is intended as a bit of sugar to avoid returning irrelevant fields based on the contact type of the row. I'd prefer it do nothing instead of crash, and in this case I think it's best for it to do nothing rather than muck with data that's already aggregated.