Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[php8.x] Fully remove interaction with _params from backoffice participant form #28645

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Dec 14, 2023

Overview

This removes the last places _params was accessed & adds a comment to switch to __get for any external access to it.
We can't quite do that in this commit as there is one place in a shared function that sets a different undeclared property - we can tackle that by unsharing that function in #28646 & then removing it from the unshared function

Note this also removes the expiry date from the template. I can't find the discussion we had about this (maybe on chat) but it was generally agreed that since we hadn't added a column for this in the DB it made sense to exclude from the template (as the template should be the same however it is sent). There was some difference of opinion about whether it should have stored in the DB though

Before

_params is hardly used in this form & it is hard to know what it 'means' as it has no clear contract but it still causes php 8.x errors

After

By removing it & offering up a __get external callers have space to transition off this method to a supported method to get the submitted values

Technical Details

The only thing that was still in use that was accessing _params was the template assignments for the workflow template - these are slated for removal in favour of tokens but for now the assignment is just moved into the form

Comments

Copy link

civibot bot commented Dec 14, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 14, 2023
@eileenmcnaughton eileenmcnaughton changed the title Fully remove interaction with _params from participant form [php8.x] Fully remove interaction with _params from participant form Dec 14, 2023
@eileenmcnaughton eileenmcnaughton changed the title [php8.x] Fully remove interaction with _params from participant form [php8.x] Fully remove interaction with _params from backoffice participant form Dec 14, 2023
This removes the last places _params was accessed & adds a __get for any external access to it

Note this also removes the expiry date from the template. I can't find
the discussion we had about this (maybe on chat) but it was generally agreed that
since we hadn't added a column for this in the DB it made sense to exclude from
the template (as the template should be the same however it is sent).
There was some difference of opinion about whether it should have
stored in the DB though
@eileenmcnaughton
Copy link
Contributor Author

thanks @mattwire

@eileenmcnaughton eileenmcnaughton deleted the params branch December 14, 2023 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants