[php8.x] Fully remove interaction with _params
from backoffice participant form
#28645
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This removes the last places _params was accessed & adds a comment to switch to __get for any external access to it.
We can't quite do that in this commit as there is one place in a shared function that sets a different undeclared property - we can tackle that by unsharing that function in #28646 & then removing it from the unshared function
Note this also removes the expiry date from the template. I can't find the discussion we had about this (maybe on chat) but it was generally agreed that since we hadn't added a column for this in the DB it made sense to exclude from the template (as the template should be the same however it is sent). There was some difference of opinion about whether it should have stored in the DB though
Before
_params
is hardly used in this form & it is hard to know what it 'means' as it has no clear contract but it still causes php 8.x errorsAfter
By removing it & offering up a
__get
external callers have space to transition off this method to a supported method to get the submitted valuesTechnical Details
The only thing that was still in use that was accessing
_params
was the template assignments for the workflow template - these are slated for removal in favour of tokens but for now the assignment is just moved into the formComments