SMS Provider searchkit admin ui #28512
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
pradpnayak
force-pushed
the
providersearchkit
branch
from
39e1ac7 to
4f04fda
Compare
|
@pradpnayak looks good. I've merged the API entity PR. Can you update your 2nd screenshot? |
pradpnayak
force-pushed
the
providersearchkit
branch
from
4f04fda to
288ac05
Compare
colemanw
reviewed
Dec 10, 2023
| 'style' => 'default', | ||
| 'path' => '', | ||
| 'action' => '', | ||
| 'condition' => [], |
There was a problem hiding this comment.
Suggested change
| 'condition' => [], | |
| 'condition' => ['is_active', '=', FALSE], |
colemanw
reviewed
Dec 10, 2023
| 'style' => 'default', | ||
| 'path' => '', | ||
| 'action' => '', | ||
| 'condition' => [], |
There was a problem hiding this comment.
Suggested change
| 'condition' => [], | |
| 'condition' => ['is_active', '=', TRUE], |
colemanw
reviewed
Dec 10, 2023
| 'version' => 4, | ||
| 'values' => [ | ||
| 'name' => 'SMS_Provider_Table_1', | ||
| 'label' => E::ts('SMS Provider Table 1'), |
There was a problem hiding this comment.
Suggested change
| 'label' => E::ts('SMS Provider Table 1'), | |
| 'label' => E::ts('SMS Provider'), |
|
@pradpnayak can you check the above suggestions? |
colemanw
reviewed
Mar 1, 2024
| 'values' => [ | ||
| 'name' => 'SMS_Provider', | ||
| 'label' => E::ts('SMS Provider'), | ||
| 'api_entity' => 'Provider', |
There was a problem hiding this comment.
Per #29555 this will need to be changed to
Suggested change
| 'api_entity' => 'Provider', | |
| 'api_entity' => 'SmsProvider', |
|
Closing in profit of #29567 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
SMS Provider search kit for admin UI replacement
Before:
After:
Requires: #28512