Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert .aff.json to .aff.php and add ts() #28499

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

ufundo
Copy link
Contributor

@ufundo ufundo commented Dec 5, 2023

Overview

Convert outstanding .aff.json afform files to .aff.php and add translation to the title.

Before

Files don't have translation

After

Titles have translation.

Technical Details

Scripted but can't see anything that's slipped through..

Copy link

civibot bot commented Dec 5, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Dec 5, 2023
@colemanw
Copy link
Member

colemanw commented Dec 5, 2023

Thanks for this @ufundo - the style checker is complaining about missing eof newlines, but otherwise looks perfect.

@ufundo
Copy link
Contributor Author

ufundo commented Dec 5, 2023

One day I will remember to run the linter before pushing or get round to configuring a git hook...

Updated now

@colemanw
Copy link
Member

colemanw commented Dec 8, 2023

@ufundo if you get a chance, I think we could be nicer to our translation team by not making them translate nonsense strings from files that belong to unit tests (like ts('Weird Name') could be unwrapped).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants