hook_civicrm_links - Add more weights #27710

totten · 2023-10-03T07:03:13Z

Overview

This adds onto a series of 5.66 PRs which aimed to normalize the handling of hook_civicrm_links and the weight property. (ping @eileenmcnaughton)

More unweighted items.

More weighted items.

These were examples identified by hook_civicrm_links - Add docblocks and event-checker #27484 (which introduced a generic validator).
These lists are impacted:
- contribution.edit.action
- file.manage.delete
- financialItem.batch.row
- Payment.edit.action

- contribution.edit.action - file.manage.delete - financialItem.batch.row - Payment.edit.action

civibot · 2023-10-03T07:03:15Z

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

hook_civicrm_links - Add more weights:

36d6ab7

- contribution.edit.action - file.manage.delete - financialItem.batch.row - Payment.edit.action

civibot bot added the 5.66 label Oct 3, 2023

totten mentioned this pull request Oct 3, 2023

hook_civicrm_links - Add docblocks and event-checker #27484

Merged

eileenmcnaughton merged commit 95b5e8a into civicrm:5.66 Oct 3, 2023