PHP8.2 Remove undefined property userName

[eileenmcnaughton]

Overview

This is causing issues on a bunch of classes when the shared code defines it - but in fact is only used on the ContributionForm

Before

After

Property not defined, getContactValue() used

Technical Details

Comments

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[demeritcowboy]

This seems to cause the contributor name to disappear from the contribution if you create it from their contact record's contribution tab.
Rebuilding test site here to check if it's some local weirdness. jenkins retest this please.

[demeritcowboy]

Hmm test site seems to agree that it can't find the contact.

[eileenmcnaughton]

@demeritcowboy it was picking up getContactID() from the trait not the parent. I have copied it onto the class & it works.

I do ponder removing it from the trait but I also see the parent's days as numbered or it's functionality to be reduced - in general I'm trying to put consistent functions like getContactID(), getPartiipantID() etc on the forms that are appropriate to the given form. Most of the rest of the logic can be more generic once you know those functions are reliable

[eileenmcnaughton]

[demeritcowboy]

ok cool