Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[REF] Update Zetacomponents/mail to be 1.9.5 to fix email validation handling" #27394

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Revert "[REF] Update Zetacomponents/mail to be 1.9.5 to fix email validation handling" #27394

merged 1 commit into from
Sep 12, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

This reverts commit 020a117.

Let's re-visit in master cos this turns out to be a bit more complicated see zetacomponents/Mail#90

There was no particular driver for this to be in 5.66 - it just got pulled in cos I successfully prodded the upstream merger to merge it. So let's slow it down & worry about it in master

Note that the other email bounce processor work is unrelated

@civibot
Copy link

civibot bot commented Sep 12, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the 5.66 label Sep 12, 2023
@eileenmcnaughton eileenmcnaughton merged commit 279875e into civicrm:5.66 Sep 12, 2023
wmfgerrit pushed a commit to wikimedia/wikimedia-fundraising-crm that referenced this pull request Sep 12, 2023
@eileenmcnaughton
Further updates to 5.66rc
39a2d37 
This includes updates I've worked on to allow us to store Bounced emails
as actitivies (we will also need to add is_create_activities to our
fetch_bounces job & create an activity type of Bounce - we can do the
former manually while testing & update our job when all good)

civicrm/civicrm-core#27356

In addition
I reverted the 5.66 change to zeta components in 5.66 since
it caused the problem Elliott plugged - this isn't the final
word but it means we will be running stock
civicrm/civicrm-core#27394

Note the commented out upgrade bits can go now we've done the upgrade
and there are some other minor patches

Bug: T346088
Bug: T345929

Change-Id: I6a27223850b361eacdd76a457963db47b0e9f1f5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
5.66 merge on pass
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eileenmcnaughton @colemanw