Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dev/core#4559 Don't include test, template, deleted entities in SearchDisplay totals #27383

Merged
merged 1 commit into from
Sep 10, 2023
Merged

dev/core#4559 Don't include test, template, deleted entities in SearchDisplay totals #27383

merged 1 commit into from
Sep 10, 2023

Conversation

larssandergreen
Copy link
Contributor

@larssandergreen larssandergreen commented Sep 9, 2023 •
edited
Loading

Overview

See issue. Put this on 5.66. Don't think it is a regression as it has always been like this, but it's a fairly recent bug.

Before

Totals include test, template, deleted entities when table results do not.

After

Totals do not include test, template, deleted entities when table results do not.

@civibot
Copy link

civibot bot commented Sep 9, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@civibot civibot bot added the master label Sep 9, 2023
@civibot
Copy link

civibot bot commented Sep 9, 2023

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4559

@larssandergreen larssandergreen force-pushed the Fix-SearchDisplay-totals branch from af469ab to b688871 Compare September 9, 2023 18:52
@larssandergreen larssandergreen changed the base branch from master to 5.66 September 9, 2023 18:52
@civibot civibot bot added 5.66 and removed master labels Sep 9, 2023
@colemanw colemanw merged commit 5f7e0d7 into civicrm:5.66 Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@colemanw colemanw colemanw left review comments

Assignees
No one assigned
Labels
5.66 has-test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@larssandergreen @colemanw