Remove some unused undefined properties from participant export #27298
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Remove some unused undefined properties from participant export
Before
$this->_newParticipant[] = $newParticipant->id;
is an undefined property (the property has an 's') - however the property is only written to because the getter for itgetImportedParticipations()
is never called. It would have become obsolete when we updated the import code to use queues because prior to that the whole import was tracked in a single request. We save the participant IDs to the import table nowAfter
Obsolete code removed
Technical Details
Comments