Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Convert from session status to deprecation warning #27255

Merged

Conversation

seamuslee001
Copy link
Contributor

Overview

A brief description of the pull request. Keep technical jargon to a minimum. Hyperlink relevant discussions.

Before

What is the old user-interface or technical-contract (as appropriate)?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

After

What changed? What is new old user-interface or technical-contract?
For optimal clarity, include a concrete example such as a screenshot, GIF (LICEcap, SilentCast), or code-snippet.

Technical Details

If the PR involves technical details/changes/considerations which would not be manifest to a casual developer skimming the above sections, please describe the details here.

Comments

Anything else you would like the reviewer to note

@civibot
Copy link

civibot bot commented Sep 1, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@eileenmcnaughton
Copy link
Contributor

OK - this will trigger errors in tests & dev experience so that makes sense

@eileenmcnaughton
Copy link
Contributor

Hmm - tests failing - I wonder if they are bad tests or a problem. I'm still in the back office participant tests but can check those next

@colemanw
Copy link
Member

colemanw commented Sep 4, 2023

It looks like this affects 5.64. Should we backport?

@eileenmcnaughton
Copy link
Contributor

test this please

1 similar comment
@seamuslee001
Copy link
Contributor Author

test this please

@eileenmcnaughton
Copy link
Contributor

test this please

  Failed to extract civicrm/civicrm-core:angular-jquery-dialog-service: (  
  1. '/nix/store/1455vmxwb4scsi53ahq11xxy72k35p97-unzip-6.0/bin/unzip' -qq '/
    home/homer/buildkit/build/build-0/web/sites/all/modules/civicrm/vendor/comp
    oser/tmp-69ab277613078138dc0d17163c85df59.zip' -d '/home/homer/buildkit/bui
    ld/build-0/web/sites/all/modules/civicrm/vendor/composer/2e7dae9c'

@colemanw
Copy link
Member

colemanw commented Sep 5, 2023

retest this please

@eileenmcnaughton
Copy link
Contributor

I don't think the test fails relate

@eileenmcnaughton eileenmcnaughton merged commit e11f828 into civicrm:master Sep 5, 2023
@eileenmcnaughton eileenmcnaughton deleted the dep_warning_participant_trait branch September 5, 2023 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants