avoid double clicks on petition page

[jmcclelland]

Overview

Avoid double clicks of a Petition, following the lead set by this PR.

Before

Periodically, I see a pattern in petition signatures: One regular signature followed by one signature in which the contact name, address and email are empty. There is nothing in the contact record except the petition signature activity. The timestamps are the same. I can't be sure this is a double click, but it seems likely (and unfortunatley I can't figure out how to replicate - no matter how hard and fast I click my little mouse I still only get one signature).

After

Well, to be honest, nothing detectable by me has changed. However, signing still works and I am hoping we stop getting the double signature.

Comments

Open to suggestions on how to properly test or alternative theories on why this might be happening. Thanks!

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[colemanw]

@jmcclelland I had been wondering if anyone still uses CiviPetition forms instead of FormBuilder, I guess this answers my question!

FYI you made the style checker grumpy:

You must use "/**" style comments for a member variable comment

[jmcclelland]

Oh - thanks! For some reason my civilint is not behaving. I just fixed it.

And yes - we have a lot of groups using Petition - in particular with the petition email extension that automatically sends an email to a target.

I haven't really looked into replicating that with form builder but maybe that's an opportunity.

[colemanw]

@jmcclelland any chance you could squash these commits down to 1?

[jmcclelland]

Yup - got it :)

[demeritcowboy]

Unrelated concurrency test fail.