Add weights to membership type links

[eileenmcnaughton]

This includes moving the financial acl permissioning of those links to the financialacls extension (since there was already an affected test in that extension too).

[civibot]

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers...

• ➡️ PR Demo site (can be rebuilt with the command test this please).
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

➡️ Online demo of this PR 🔗

[eileenmcnaughton]

I had to loosen the type hinting - I could fix pcpLinks to pass objectID but not 'block'

[seamuslee001]

@eileenmcnaughton also the manage extensions page passes through a string in the objectId not an int

[colemanw]

@eileenmcnaughton this appears to have caused a regression. To reproduce

1. Log into a civibuild site as the "demo" user.
2. Navigate to civicrm/admin/member/membershipType?reset=1.
3. View/edit links are no longer visible.

[eileenmcnaughton]

argh the issue is probably that the extension is enabled for everyone - regardless of whether they want these acls - so it needs to check the setting

[colemanw]

@eileenmcnaughton is "the setting" now redundant with "the extension is enabled"? And if so should the upgrade code check the setting, conditionally enable the extension based on the setting, and then we can delete the setting?

[eileenmcnaughton]

@colemanw the problem is the extension is 'enabled for all' - I'm not sure if we can safely disable it or now - there is still code in core that should be in the extension but perhaps that doesn't cause issues when we disable