Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contribution page tokens to contribution tokens #27201

Merged
merged 1 commit into from
Sep 5, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

@eileenmcnaughton eileenmcnaughton commented Aug 30, 2023

Overview

Add contribution page tokens to contribution tokens

Before

Tokens not available

After

A small handful are

Technical Details

@larssandergreen this is a reviewers cut of the token portion of the changes in #27173 - the main change is that I added some extra tokens that I could see would be required in the online contribution template

My other focus was to work through the code & understand where the html handling would best be done. I have some thoughts based on this - which I will put up separately. Note the test I put up is just where I was most comfortable putting it - I suggest we add both this one & your test tweaks (once this all passes)

Comments

Update - I think the line break handling best lives in the coversion within the token - ie #27204 and #27203

@civibot
Copy link

civibot bot commented Aug 30, 2023

🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷

Introduction for new contributors...
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers...

➡️ Online demo of this PR 🔗

@larssandergreen larssandergreen added the merge ready PR will be merged after a few days if there are no objections label Sep 5, 2023
@colemanw
Copy link
Member

colemanw commented Sep 5, 2023

Test cover looks good

@colemanw colemanw merged commit cce5a2b into civicrm:master Sep 5, 2023
@colemanw colemanw deleted the page_tokens branch September 5, 2023 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants