[REF] Remove unreachable handling #27192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
generatePane is only called from one function & those calls have either AdditionalDetail or Premium as the type - the rest of the handling in the function apparently relates to before we used the payment form load method (a long time ago)
|
|
||
| if ($dao->find(TRUE) && empty($this->_payNow)) { | ||
| $paneNames[ts('Premium Information')] = 'Premium'; | ||
| if ($dao->find(TRUE)) { |
There was a problem hiding this comment.
the payNow check is removed as I moved it inside the relevant IF
|
🤖 Thank you for contributing to CiviCRM! ❤️ We will need to test and review this PR. 👷 Introduction for new contributors...
Quick links for reviewers...
|
eileenmcnaughton
added a commit
to eileenmcnaughton/civicrm-core
that referenced
this pull request
Aug 29, 2023
Per civicrm#27192 hidden_CreditCard is always empty so the check is meaningless. The newer boolean token check is safer than the quoted string check
|
fail looks leap-year related - I think it might be failing all day |
larssandergreen
pushed a commit
to larssandergreen/civicrm-core
that referenced
this pull request
Sep 6, 2023
Per civicrm#27192 hidden_CreditCard is always empty so the check is meaningless. The newer boolean token check is safer than the quoted string check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generatePane is only called from one function & those calls have either AdditionalDetail or Premium as the type - the rest of the handling in the function apparently relates to before we used the payment form load method (a long time ago)