-
-
Notifications
You must be signed in to change notification settings - Fork 825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support retention of locale on links #27128
Conversation
Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷 Introduction for new contributors
Quick links for reviewers |
Anyone able to explain the test failure? I can't figure out what's failed. |
Yea those messages are pretty unhelpful. Let's try again: retest this please |
retest this please Test failure looks "wrong" |
@kcristiano the test problem is resolved - this appears to be a purely Wordpress PR so I'll wait on your merge-request |
We've been running this in prod for a while now (2-4 weeks?) and works well. We also have other sites running WPML, with Shane's patch (based on PR 289 in the WP repo, adapted to the new structure), and both play well together. |
@colemanw if this is otherwise good we could probably change branch & merge to the rc since it probably will still switch base cleanly |
Merging per review/testing by @mlutfy |
Thanks 👍 |
Overview
Solves this issue on Lab.
Before
getUFLocale()
method.After
url()
method to generate front-end URLs that contain locale information as defined by 3rd party plugins.getUFLocale()
method to support front-end locales as defined by 3rd party plugins.Technical Details
Requires this PR on CiviCRM-WordPress.