Concurrency Tests - Update ExternalBatch for symfony/process v4.1+ (esp Drupal 10) #27072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before ------ `api_v3_JobProcessMailingTest::testConcurrency()` and `Civi\FlexMailer\ConcurrencyTest` fail when executed on Drupal 10. After ----- Pass when executed on Drupal 10 Technical Details ----------------- `symfony/process` v4.1 deprecated the usage of `new Process(string)` and added `Process::fromShellCommandline(string)`. The `new Process(string)` was dropped from v5.x and v6.x. So you get an unconditional failure on D10. (On other platforms, it can also fail... depending on how you deal with deprecations.) In `civicrm-core:composer.json`, the minimum mversion of `symfony/process` is `4.4`. So that means we can use the newer `Process::fromShellCommandline(string)`.
|
Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷 Introduction for new contributors
Quick links for reviewers |
|
To run the tests on D10, one can use https://test.civicrm.org/job/CiviCRM-Manual-Test/. Compare:
|
totten
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before
api_v3_JobProcessMailingTest::testConcurrency()andCivi\FlexMailer\ConcurrencyTestfail when executed on Drupal 10. The errors look like:After
These tests pass in the same environment.
Technical Details
symfony/processv4.1 deprecated the usage ofnew Process(string)and addedProcess::fromShellCommandline(string). Thenew Process(string)was dropped from v5.x and v6.x. So you get an unconditional failure on D10. (On other platforms, it can also fail... depending on how you deal with deprecations.)In
civicrm-core:composer.json, the minimum version ofsymfony/processis4.4. So that means we can use the newerProcess::fromShellCommandline(string).