dev/core#4498 Ensure that users without administer civicrm permission…

[seamuslee001]

… can use the Mailing Autocomplete

Overview

This fixes a problem where the mailing recipients autocomplete does an EntitySet.get apiv4 call and that requires administer civicrm because the permissions function doesn't correctly modify the get parameter

Before

Non Admins cannot use the CiviMail Recipients lookup

After

Non Admins can use the CiviMail Recipients look up

ping @MegaphoneJon @colemanw

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[civibot]

The issue associated with the Pull Request can be viewed at https://lab.civicrm.org/dev/core/-/issues/4498

[colemanw]

This looks right to me. @MegaphoneJon does this solve it on your end?

[MegaphoneJon]

@seamuslee001 @colemanw I just did an r-run and it fixes the issue. Though I did notice that the widget displays unsent mailings as an option, which is neither consistent with past behavior nor (imo) desirable. I'll see if I can write a patch.

[MegaphoneJon]

On review, it seems like a pretty intentional decision to include unsent mailings. @colemanw I'm not gonna do a patch unless you think otherwise.

[mlutfy]

I don't have a strong opinion on it, but I can see valid cases for including unsent mailings:

• plan a communication campaign to all members
• schedule a mailing specific to major donors
• then schedule a mailing to all other contacts, exclude major donors

You could just exclude the group, but if you're working with mailing recipients for some reason, sometimes people schedule all mailings, and send them all on the same day, so it can be useful to not exclude drafts (my example happened to have an easy workaround, but sometimes there isn't).

(I remember a while back, it was not possible to clone/copy a draft mailing, for example; this seems similar)

[larssandergreen]

Also chiming in to say that excluding unsent mailings is desirable (and has been the past behaviour, as far as I know).

[seamuslee001]

I'm going to merge this based on the fact it fixes the hard fail but will open a gitlab in regards to the unsent mailings question

[seamuslee001]

Gitlab is https://lab.civicrm.org/dev/core/-/issues/4508