(REF) civicrm_data.tpl - Stop using Smarty's {php}

[totten]

Overview

Tweak the generation of install data (with an eye toward forward compatibility).

Before

Load data file with inline {php}

{php}echo (include "sql/civicrm_data/civicrm_location_type.sqldata.php")->toSQL();{/php}

After

Load data file with {crmSqlData} helper

{crmSqlData file="sql/civicrm_data/civicrm_relationship_type.sqldata.php"}

Comments

This is a pre-req to trying out newer Smarty versions.

To test, I used this approach:

./bin/setup.sh -g
cp sql/civicrm_data.mysql{,-orig}
./bin/setup.sh -g
diff -u sql/civicrm_data.mysql{-orig,}

The only changes were a few blank newlines.

Note that {crmSqlData} is more locked-down than {php} -- i.e. it only reads from the sql/ folder, and it only reads *.sqldata.php files. Anything else is rejected.

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)