Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add '<browse>' links matching those in AdminUI #26921

Merged
merged 1 commit into from
Jul 24, 2023
Merged

Conversation

aydun
Copy link
Contributor

@aydun aydun commented Jul 24, 2023

Overview

This adds '' paths to the schema xml for use by #26887 for paths used in AdminUI.

Before

Not redirected to a browse page in some cases.

After

Redirected in more situations.

Technical Details

Comments

@colemanw Some of these work (ie following the sequence in #26887 goes to the browse page), but some don't. Eg: contact subtype, relationship type, financial accounts

@civibot
Copy link

civibot bot commented Jul 24, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Jul 24, 2023
@colemanw
Copy link
Member

@aydun patch failed, probably a merge conflict because your branch is slightly out-of-date. Try this:

git reset --hard HEAD~1 # delete your setup.sh commit
git pull --rebase origin master
./bin/setup.sh -g
git commit -a --amend # no need for a separate commit for setup
git push -f

@aydun
Copy link
Contributor Author

aydun commented Jul 24, 2023

Thanks @colemanw - that worked

@aydun aydun merged commit b2d2be7 into civicrm:master Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants