Remove old broken code

[eileenmcnaughton]

Overview

Remove old broken code

This code is

1. passing a non variable to a pass by reference
2. accessing a non-existant never-set property (_honoreeProfileId)

I think it is likely this code has been broken since 2014 but it's really obscure & hence probably never hit.

To hit this code it is necessary to attempt to add a pledge payment to an existing pledge via a contribution page by putting the pledgeId in the url along with the contact ID (e.g https://dmaster.localhost:32353/civicrm/contribute/transact?reset=1&id=3&pledgeId=4&cid=204). However, the pledge MUST HAVE existing completed payment/s AND at least one of those MUST have a soft credit. I hacked out the checksum lookup to get past that

Note there are multiple reasons why this might not work on your site if you try to test it - it looks up the wrong option group set to get valid statuses for example. But the worst that could happen is that a default value is not set in a very very obscure place

Before

After

poof

Technical Details

Comments

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[eileenmcnaughton]

test this please

[colemanw]

Nice catch @eileenmcnaughton