dev/core#4441 - Incorrect error "There might be a data problem, contribution id could not be loaded from the line item"

[demeritcowboy]

Overview

https://lab.civicrm.org/dev/core/-/issues/4441

Before

1. Events - Register Event Participant.
2. Pick a contact with an email.
3. Pick an event.
4. Check the box to send receipt.
5. Click Save.
6. Error: "There might be a data problem, contribution id could not be loaded from the line item"

After

Technical Details

The first part is using id when it should be entity_id.
The second part seems like incorrect flow where it should have been in an else block.

Comments

@eileenmcnaughton

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[seamuslee001]

@demeritcowboy I'm guessing we need to port this to 5.63 ?

[demeritcowboy]

No need to guess, I have a magic 8 ball. It says "No, not likely".
It's never wrong.

[agileware-justin]

How did this bug not get caught by a unit test?