Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] LocationType - Set defaults, modernize form and BAO #26878

Merged
merged 3 commits into from
Jul 20, 2023

Conversation

colemanw
Copy link
Member

Overview

Updates the LocationType schema/BAO/form to follow current standards.

Before

No field defaults, no required fields (it was possible to use the api to create a location type with NULL name!), no hooks called when saving through the BAO.create function... and the form didn't even call BAO.create it just copied the code from it!

After

Sanity.

@civibot
Copy link

civibot bot commented Jul 19, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Jul 19, 2023
@colemanw colemanw force-pushed the locationTypeFixes branch 3 times, most recently from d51bddf to e9f0a5b Compare July 19, 2023 21:38
@seamuslee001
Copy link
Contributor

@colemanw test fail relates

Cannot execute UPDATE `civicrm_location_type` SET `display_name_en_US` = `name` WHERE `display_name_en_US` IS NULL;, UPDATE `civicrm_location_type` SET `display_name_af_ZA` = `name` WHERE `display_name_af_ZA` IS NULL;, UPDATE `civicrm_location_type` SET `display_name_bg_BG` = `name` WHERE `display_name_bg_BG` IS NULL: DB Error: syntax error

@colemanw colemanw force-pushed the locationTypeFixes branch from e9f0a5b to f71407e Compare July 19, 2023 22:57
@colemanw
Copy link
Member Author

@seamuslee001 how about adding a MOP label when you drive-by!

@colemanw colemanw force-pushed the locationTypeFixes branch from f71407e to 7f7d8c7 Compare July 20, 2023 00:43
@mlutfy mlutfy merged commit ac9ed92 into civicrm:master Jul 20, 2023
@colemanw colemanw deleted the locationTypeFixes branch November 9, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants