God has answered

[colemanw]

Overview

Answers a long-standing theological question.

Before

"Dear God why did I have to write this?"

After

"Dear Tim, behold what you have written, for it is good. CRM_Utils_SQL_Select bestows upon CiviCRM the divine gifts of APIv4, and SearchKit, and Smart Groups with hookable queries. Begone foul demons of query string manipulation, and rejoice at the good news of object-oriented query building!"

@totten

[civibot]

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors

• If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
• For more information about contributing, see CONTRIBUTING.md.

Quick links for reviewers

• ➡️ Demo site for this PR
• 📖 Review standards
• 🗒️ Review template (brief or verbose)

[demeritcowboy]

Actually it's more likely the oracle would answer.

And if god had wanted us to query he would have given us indexes.

[eileenmcnaughton]

So I guess it turns out Coleman has answered === god had answered so Coleman === god ?

[colemanw]

Not at all, I merely received god's answer by ascending to the top of the class hierarchy and beholding that Tim's SQL builder is indeed useful. I carved those words into the docblock and came down to share the good news with the world. Call me a prophet :)

[demeritcowboy]

I've marked as needs-test since we don't want the existence of god or this new prophet feature to get broken in future versions. Shouldn't be too hard to write such a test.

[mattwire]

I am GOD.

[demeritcowboy]

Needs documentation.

[colemanw]

@demeritcowboy perhaps we can re-use existing documentation via

<import>scripture</import>

[demeritcowboy]

Hehe. I think you'd have to specify min version since there's no Matthew in the earlier versions. Although I notice the Jesus feature is a bit broken in recent versions (regression?).

[colemanw]

The version history is a bit convoluted, as it pre-dates vcs and sem-ver. And it's hard to find a compiler for Aramaic these days.

[awestuk]

I thought Civi was not-for-prophet

[totten]

Question for next week's liturgy: Does Lucifer send bugs to interfere with the earthly project? Or are bugs part of the grand plan?

[kcristiano]

Bugs are to test your faith and part of the grand plan I think.

[totten]

The Code moves in Mysterious Ways.