Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Ensure that url that is stored as context is generated correctl… #26868

Conversation

seamuslee001
Copy link
Contributor

…y for backend usage in wordpress

Overview

On a client site I found that I was being redirected to a front end style url wp-admin/civicrm/admin/ which didn't work but running this through url() fixed the problem

Before

url not correctly formatted when pushed into pushScope

After

Wrap the url in a call to url() function to ensure backend url is correctly formatted

ping @kcristiano @eileenmcnaughton

@civibot
Copy link

civibot bot commented Jul 18, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Jul 18, 2023
@demeritcowboy
Copy link
Contributor

Putting merge-ready just in case there's something wordpress-specific here. e.g. maybe "forceBackend" has some meaning (it doesn't in drupal)

@demeritcowboy demeritcowboy added the merge ready PR will be merged after a few days if there are no objections label Jul 18, 2023
@seamuslee001 seamuslee001 merged commit 2d22a12 into civicrm:master Jul 20, 2023
@eileenmcnaughton eileenmcnaughton deleted the fix_redirect_url_payment_processor_wordpress branch July 20, 2023 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
master merge ready PR will be merged after a few days if there are no objections
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants