Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SearchKit - Improve performance of checking link permissions #26854

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

colemanw
Copy link
Member

Overview

Speeds up search display performance by checking link permissions more efficiently.

Before

Link permissions checked one-at-a-time, resulting in hundreds of internal calls to the checkAccess api per request.

After

Gatekeeper permissions checked once in bulk. Fine-grained ACLs checked without the overhead of the api wrapper. Test coverage added to make sure it still works.

@eileenmcnaughton

@civibot
Copy link

civibot bot commented Jul 16, 2023

Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷

Introduction for new contributors
  • If this is your first PR, an admin will greenlight automated testing with the command ok to test or add to whitelist.
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command test this please to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • To ensure that you are credited properly in the final release notes, please add yourself to contributor-key.yml
  • For more information about contributing, see CONTRIBUTING.md.
Quick links for reviewers

@civibot civibot bot added the master label Jul 16, 2023
@colemanw colemanw force-pushed the searchKitLinkPerformance branch from 6b2d8bf to 7e82b21 Compare July 16, 2023 18:22
@colemanw colemanw force-pushed the searchKitLinkPerformance branch from 7e82b21 to 2f99b58 Compare July 16, 2023 18:23
@eileenmcnaughton
Copy link
Contributor

Seems to work fine

@eileenmcnaughton eileenmcnaughton merged commit d9718ed into civicrm:master Aug 2, 2023
@eileenmcnaughton eileenmcnaughton deleted the searchKitLinkPerformance branch August 2, 2023 22:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants