-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Search kit action links cleanup #26839
Search kit action links cleanup #26839
Conversation
Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷 Introduction for new contributors
Quick links for reviewers |
api\v4\SearchDisplay\SearchRunTest::testActionAndTaskLinks /home/homer/buildkit/build/build-3/web/sites/all/modules/civicrm/ext/search_kit/Civi/Api4/Action/SearchDisplay/AbstractRunAction.php:477 |
14ad0ef
to
f5a57e7
Compare
@colemanw my one concern about this is that we are seeing some speed issues related to the links. I think the worst of it might be the fixed one with the downloads - but I'm just wondering if this will increase api calls & by how much? It looks like maybe just once per Search load? |
@eileenmcnaughton yea I've been looking at that. I think the speed issues can be further improved with a bit of caching. But I don't think this PR is making it significantly worse. |
Overview
Followup to #26794 with some improvements to the code to make it more efficient and responsive. Also improves the UX by hiding links the user can't actually click on.
Technical Details