[REF] [PHP8.2] Post unshare cleanup #26832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stops passing & returning unused values from the previously shared function & removes a deprecated chunk. This deprecation was very precautionary IMHO so 6 months is long enough
|
Thank you for contributing to CiviCRM! ❤️ We will need to test and review the PR. 👷 Introduction for new contributors
Quick links for reviewers |
eileenmcnaughton
force-pushed
the
unshared
branch
2 times, most recently
from
f4b3d8a to
e4dfc16
Compare
eileenmcnaughton
changed the title
| @@ -108,11 +102,9 @@ private function setGroupTree(&$form, $subType, $gid, $onlySubType = NULL, $getC | |||
| foreach ($keys as $key) { | |||
| $form->_groupTree[$key] = $groupTree[$key]; | |||
| } | |||
| return [$form, $groupTree]; | |||
There was a problem hiding this comment.
We don't need an empty return cos after this & the else the function ends
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This stops passing & returning unused values from the previously shared function & removes a deprecated chunk.
Before
getCachedTreeis always TRUE and the return is never usedAfter
The above are removed - I ALSO removed a deprecated chunk
This deprecation was very precautionary IMHO as it relates to custom separators in the urls - so 6 months is long enough