Fix PHP errors on profiles and custom fields when using options per line

[larssandergreen]

Overview

Five more fixes for this strange counting to ten pattern previously covered in #26757 and #26517, fixing regressions due to #26265. These should be all of them, based on searching.

This should be included in 5.64 and backported to 5.63, since that's where the regression came into play.

Before

Five places where PHP 8 errors cause a crash, all when you have a custom field with options per line set:

1. Previewing the custom field from custom fields
2. Previewing a profile with a custom field
3. Using a profile in Create mode, etc
4. Batch update on contacts with profile with custom field
5. Batch update on participants with profile with custom field

After

All good.

[civibot]

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

• If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• Here are some handy links for reviewers:
  • Demo site for this PR
  • Review standards
  • Review template

[demeritcowboy]

Thanks @larssandergreen. It would be funnier if there were 10 instances. We're at 7 so let's keep looking. And I think we can assume there can't possibly ever be more than 10...