Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unneeded and strange profile field save success alert #26751

Conversation

larssandergreen
Copy link
Contributor

@larssandergreen larssandergreen commented Jul 6, 2023

Before

Strange success message when saving a profile field.
image

After

No more success message.

Comments

I don't think we need to alert the user that we successfully saved a profile field. Profiles are more of an admin area and we don't need to alert the user to every successful save here.

@civibot
Copy link

civibot bot commented Jul 6, 2023

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

  • If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • Here are some handy links for reviewers:

@civibot civibot bot added the master label Jul 6, 2023
@larssandergreen larssandergreen changed the title Remove unneeded and strange profile field save confirm alert Remove unneeded and strange profile field save success alert Jul 6, 2023
@demeritcowboy demeritcowboy merged commit 8aff454 into civicrm:master Jul 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants