(dev/core#4391) Prohibit uninstallation of core components #26743
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
In 5.63, each core
Component
(eg CiviMail) has a correspondingExtension
(egcivi_mail
). However, extensions support more lifecycle actions - esp. theuninstall
action - which don't make sense for components.See: https://lab.civicrm.org/dev/core/-/issues/4391
Before
You are allowed to submit a request to
uninstall
a component-extension. But it doesn't entirely work; and then the subsequent re-installation fails.After
You are not allowed to
uninstall
a component-extension.Technical details
Compare traditional lifecycles of
Component
s andExtension
s:The problem is that "Uninstalled" doesn't make sense for a "Component" (where data-structures are always, regardless of whether it's been enabled).