Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dev/core#4391) Prohibit uninstallation of core components #26743

Merged
merged 2 commits into from
Jul 5, 2023

Conversation

totten
Copy link
Member

@totten totten commented Jul 5, 2023

Overview

In 5.63, each core Component (eg CiviMail) has a corresponding Extension (eg civi_mail). However, extensions support more lifecycle actions - esp. the uninstall action - which don't make sense for components.

See: https://lab.civicrm.org/dev/core/-/issues/4391

Before

You are allowed to submit a request to uninstall a component-extension. But it doesn't entirely work; and then the subsequent re-installation fails.

After

You are not allowed to uninstall a component-extension.

Technical details

Compare traditional lifecycles of Components and Extensions:

Status Component Extension
Enabled Code and data both active. Code and data both active.
Disabled Code inactive. Data still retained. Code inactive. Data still retained.
Uninstalled (Not applicable) Code inactive. Data removed.

The problem is that "Uninstalled" doesn't make sense for a "Component" (where data-structures are always, regardless of whether it's been enabled).

@civibot
Copy link

civibot bot commented Jul 5, 2023

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

  • If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • Here are some handy links for reviewers:

@civibot civibot bot added the 5.63 label Jul 5, 2023
@totten
Copy link
Member Author

totten commented Jul 5, 2023

@larssandergreen @colemanw - Test suites are OK with this.

@colemanw
Copy link
Member

colemanw commented Jul 5, 2023

I'm ok with it too 👍

@colemanw colemanw merged commit 6d0f68f into civicrm:5.63 Jul 5, 2023
@totten totten deleted the 5.63-comp-uninstall branch July 5, 2023 20:43
@larssandergreen
Copy link
Contributor

Makes sense to me and no issues on r-run, thanks @totten.
I did notice while testing that I confused two separate problems in the issue, so I've posted another as there is still a problem when you disable as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants