Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NFC: Add debug level log message when afform submissions catch exceptions #26741

Merged

Conversation

artfulrobot
Copy link
Contributor

The code comments suggest we don't really know what to do here, previously we did nothing, which was not helpful to a developer trying to figure out why their code did nothing.

Now we emit the exception's message to the log file.

The code comments suggest we don't really know what to do here,
previously we did nothing, which was not helpful to a developer
trying to figure out why their code did nothing.

Now we emit the exception's message to the log file.
@civibot
Copy link

civibot bot commented Jul 5, 2023

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

  • If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
  • A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
  • A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
  • If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
  • Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
  • A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
  • Here are some handy links for reviewers:

@civibot civibot bot added the master label Jul 5, 2023
@artfulrobot artfulrobot mentioned this pull request Jul 5, 2023
@mattwire
Copy link
Contributor

mattwire commented Jul 5, 2023

Seems ok - similar to #25533 that I added recently - maybe add 'afform' as log prefix ie. \Civi::log('afform')->debug

@artfulrobot
Copy link
Contributor Author

@mattwire ok, done that.

@eileenmcnaughton
Copy link
Contributor

Merging as it makes sense & @mattwire's feedback is in favour & incorporated already

@eileenmcnaughton eileenmcnaughton merged commit 0eb62e4 into civicrm:master Jul 5, 2023
@artfulrobot artfulrobot deleted the help-debug-afform-submissions branch July 6, 2023 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants