Update related contribution trxn_id before sending email [must go into 5.64]

[eileenmcnaughton]

Overview

Update related contribution trxn_id before sending email

Before

When a comtribution is completed by adding a payment an email goes out. However, this happens before the trxn_id is updated on the contribution, resulting in the trxn_id not including the relevant payment

After

The update happens before completecontribution is called, meaning the trxn_id is saved before the email goes out

Technical Details

This will allow #26659 to pass & merge

Comments

[civibot]

Thank you for contributing to CiviCRM! ❤️ Here's what's next:

• If this is your first PR, an admin will greenlight automated testing with the command "add to whitelist".
• A series of tests will automatically run. You can see the results at the bottom of this page (if there are any problems, it will include a link to see what went wrong).
• A demo site will be built where anyone can try out a version of CiviCRM that includes your changes.
• If this process needs to be repeated, an admin will issue the command "test this please" to rerun tests and build a new demo site.
• Before this PR can be merged, it needs to be reviewed. Please keep in mind that reviewers are volunteers, and their response time can vary from a few hours to a few weeks depending on their availability and their knowledge of this particular part of CiviCRM.
• A great way to speed up this process is to "trade reviews" with someone - find an open PR that you feel able to review, and leave a comment like "I'm reviewing this now, could you please review mine?" (include a link to yours). You don't have to wait for a response to get started (and you don't have to stop at one!) the more you review, the faster this process goes for everyone 😄
• Here are some handy links for reviewers:
  • Demo site for this PR
  • Review standards
  • Review template