Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NFC] Update test that's no longer doing what it was doing #26725

Merged
merged 1 commit into from
Jul 4, 2023

Conversation

demeritcowboy
Copy link
Contributor

@demeritcowboy demeritcowboy commented Jul 4, 2023

Overview

Let's see what I can break. Followup to #26615.

Before

The test was originally pointing out a fail in real sites that wasn't in the test installs.

After

The related stock entries have since been removed from installs, with just the Everyone remaining. It has no effect on this particular test but having it for every test simulates a real install a little closer.

Technical Details

Comments

Not sure if there's a better place to put this.

@civibot
Copy link

civibot bot commented Jul 4, 2023

(Standard links)

@demeritcowboy demeritcowboy changed the title [WIP][NFC] Update test that's no longer doing what it was doing [NFC] Update test that's no longer doing what it was doing Jul 4, 2023
@eileenmcnaughton
Copy link
Contributor

Hardly confusing at all...

@eileenmcnaughton eileenmcnaughton merged commit b51cbfb into civicrm:master Jul 4, 2023
@demeritcowboy
Copy link
Contributor Author

demeritcowboy commented Jul 4, 2023

Yes a bit, but not as confusing as ACLs to begin with.

@demeritcowboy demeritcowboy deleted the acl branch July 4, 2023 22:33
@eileenmcnaughton
Copy link
Contributor

high bar

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants