#4360 #4384 fixing multiple regressions with path civicrm/contact/search

[samuelsov]

Overview

Issue dev/core#4360 dev/core#4384

Before

• issues when accessing search contact/search with qfKey
• crash when doing advanced search

After

Use the legacy search in most context except when using the menu

Technical Details

Using alternate path civicrm/adminui/contact/search for SearchKit/Formbuilder version

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[larssandergreen]

Confirmed, all three issues are fixed. Looks reasonable to me.

[larssandergreen]

I spoke too soon: If you disable AdminUI with this patch, Find Contacts disappears from the Search menu. It's still accessible by URL, but the menu item is gone (and even rebuilding the menu doesn't bring it back).

[samuelsov]

I spoke too soon: If you disable AdminUI with this patch, Find Contacts disappears from the Search menu. It's still accessible by URL, but the menu item is gone (and even rebuilding the menu doesn't bring it back).

Hmm, good catch. We need to add an upgrader/disable/enable functions

[colemanw]

How about instead of a managed nav-menu entry, just an enable/disable script in the upgrader class that changes the path of the existing nav-menu item.

[samuelsov]

I spoke too soon: If you disable AdminUI with this patch, Find Contacts disappears from the Search menu. It's still accessible by URL, but the menu item is gone (and even rebuilding the menu doesn't bring it back).

@larssandergreen this should be fixed. If you don't rebuild your testing instance from scratch, you need to first delete the civicrm_manage entry with :

DELETE FROM civicrm_managed WHERE name = 'Navigation_Find_Contacts';

[larssandergreen]

Works for me now, thanks @samuelsov

[demeritcowboy]

Thanks everybody.

[demeritcowboy]

The new url doesn't seem to be working anymore: civicrm/adminui/contact/search

[samuelsov]

The new url doesn't seem to be working anymore: civicrm/adminui/contact/search

@demeritcowboy it has been moved to a new extension -> #26863 so if you are in master, you need to enable it

[demeritcowboy]

Oh ok. This extension though still thinks it owns the link, so if you install adminui but not the other one then the menu link goes to the new url but it doesn't exist. See dmaster.demo.

[aydun]

I forgot to move that upgrader when moving the 'Find Contacts' search - See #26919