SearchKit - Reuse helpers from CRM_Core_Action #26663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This simplifies SearchKit code by reusing the new helpers added in cf957fc It adds an additional helper for fetching the icon associated with an action. Also fixes an action name in the CustomField DAO which did not match the name of a CRM_Core_Action (renamed 'move' to 'detach' which is the convention other entities use).
|
(Standard links)
|
|
Looks good. Tried a bunch of things with SearchKit actions and all seems good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This simplifies SearchKit code by reusing the new helpers added in cf957fc.
It adds an additional helper for fetching the icon associated with an action. Also fixes an action name in the CustomField DAO which did not match the name of a CRM_Core_Action (renamed 'move' to 'detach' which is the convention other entities use).