Fix test to use created workflow #26655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently it uses a 'real' workflow & if we change the workflow the test breaks - which is not what the test is testing. The test checks loading & rendering from the database, not a specific workflow. This fixes to create a template for the test, rather than using a real one
|
(Standard links)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix test to use created workflow
Before
Currently it uses a 'real' workflow & if we change the workflow the test breaks
After
A workflow is created for the duration of the test for it to use.
Technical Details
The test checks loading & rendering from the database, not a specific workflow. This fixes to create a template for the test, rather than using a real one
Comments
towards #26650