Add Search Display of ACLs #26624
Merged
Add Search Display of ACLs #26624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
seamuslee001
force-pushed
the
acl_search_display
branch
from
efdd004 to
6eb4eda
Compare
colemanw
reviewed
Jun 23, 2023
colemanw
reviewed
Jun 23, 2023
colemanw
reviewed
Jun 23, 2023
seamuslee001
force-pushed
the
acl_search_display
branch
from
6eb4eda to
bab8f74
Compare
colemanw
reviewed
Jun 23, 2023
Add in Search Kit and form Builder display for ACLs Update function titles following discussion with coleman and update translation in managed entity
…odify form appropriately
seamuslee001
force-pushed
the
acl_search_display
branch
from
c4be24b to
5d5ca57
Compare
|
Jenkins re test this please |
|
Hooray, passing test! |
colemanw
reviewed
Jul 21, 2023
| @@ -99,6 +105,10 @@ | |||
| <type>int unsigned</type> | |||
| <comment>The ID of the object controlled by this ACL entry</comment> | |||
| <add>1.6</add> | |||
| <pseudoconstant> | |||
| <callback>CRM_ACL_BAO_ACL::getObjectIdOptions</callback> | |||
| <prefetch>false</prefetch> | |||
There was a problem hiding this comment.
@seamuslee001 I just noticed this. Why did you add this <prefetch> flag? I'm honestly not even sure what this would do when paired with a <callback>, I don' think that's ever been done before.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This adds a search kit built search display of ACLs into the new admin ui extension and associated metadata that is needed and includes #26615
Before
No new display for list of ACLs based on search kit
After
New search kit display
ping @colemanw