dev/core#4112 Move utilities for full text search to the legacycustomsearches extension #26613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
No issue was found matching the number given in the pull request title. Please check the issue number. |
|
(Standard links)
|
|
Merging based on the lovely screenshot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
dev/core#4112 Move utilities for full text search to the legacycustomsearches extension
Before
On searching I find the
CRM_Utils_QueryFormatteris only called fromlegacycustomsearchesAbstractPartialclass and theCRM_Core_InnoDBIndexerand fts settings only exist to support itAfter
The above, including their tests, are moved to the extension
Full text search still works in an e-noticey kinda way
Full text search setting (the one that was exposed) is still on the settings page
Technical Details
I converted some settings to use our preferred mehod of injecting themselves into the page but got bored half-way through
Comments