Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete 'Basic ACLs' #26612

Merged
merged 1 commit into from
Jun 23, 2023
Merged

Remove obsolete 'Basic ACLs' #26612

merged 1 commit into from
Jun 23, 2023

Conversation

colemanw
Copy link
Member

@colemanw colemanw commented Jun 22, 2023

Overview

Removes unused code for an old permissioning system that no longer exists.

Technical Details

These 'Basic ACLs' were, as best anyone on the CT can remember, a primitive form of user-role permissions, which are now obsolete since CiviCRM utilizes permissions provided by the CMS. Based on the git/svn history, this subsystem appears to be abandoned.

Comments

  • The page and form were not in the navigation menu so were effectively hidden.
  • The page has not been updated since "participant" was added as an ACL option, so that part of it has been broken since then.
  • The installer data hasn't been touched in over a decade and is missing all recently added permissions, so that part also would be broken if anyone tried to use this.
  • We think that 'maybe' this was used by the old Standalone system, but the new one @artfulrobot is working on will not need this.

@civibot
Copy link

civibot bot commented Jun 22, 2023

(Standard links)

@civibot civibot bot added the master label Jun 22, 2023
These 'Basic ACLs' were, as best anyone on the CT can remember, a primitive form of user-role permissions,
which are now obsolete since CiviCRM utilizes user-role permissions provided by the CMS.
Based on the git/svn history, this subsystem hasn't been touched in a very long time
so is most likely unused.
@seamuslee001
Copy link
Contributor

This looks fine to me

@seamuslee001 seamuslee001 merged commit badce7e into civicrm:master Jun 23, 2023
@seamuslee001 seamuslee001 deleted the aclBasic branch June 23, 2023 03:33
@artfulrobot
Copy link
Contributor

Thanks for the mention. Interesting. Yes ACLs are going to be fun, once we're using "role" in two contexts both within Civi...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants