[REF] CiviGrant - Switch to writeRecord/deleteRecord + BAO hooks

[colemanw]

Overview

Code refactor in CiviGrant BAO to use newer code patterns.

Comments

Probably needs r-run creating and updating grants, esp checking that notes and attachments work correctly.

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[monishdeb]

Jenkins test this please

[monishdeb]

@colemanw I encountered an issue. I used the test build site http://core-26594-5azma.test-1.civicrm.org:8001 (--account-name=admin --account-pass=MTQAGHbae3F8) and on contact summary's Grant tab, when I simply submit the Grant update form it creates a new grant record each time:

On the other hand, the empty grant type on a fresh install of civigrant is another issue that I guess is covered in #25387 .

The rest are working fine, like the note and attachments are saved properly, also tried with grantapplication, did CRUD operation on grant etc.

[colemanw]

Thank you for reviewing @monishdeb - I've pushed up a fix for that (form submit function was using the old $ids pattern).

[monishdeb]

Jenkins test this please

[monishdeb]

Looks good now. I retested on test-build site and it works fine. I am not sure about an intermittent problem, as you can see in the screencast sometimes it takes too much time to save in popup edit/new grant form, but on refresh, I cannot replicate the issue again:

I repeated the same on my local but can't replicate it. I think it's just a glitch and did a thorough code review and can't find any possible cause.

[monishdeb]

Based on my review above, merging this PR.