-
-
Notifications
You must be signed in to change notification settings - Fork 824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CiviMail - New autocompletes for selecting recipients #26585
CiviMail - New autocompletes for selecting recipients #26585
Conversation
Generally improves handling of Autocomplete searchDisplays based on EntitySets
(Standard links)
|
This uses an autocomplete callback with UNIONs to select from both groups and mailings, but instead of a single widget for incluce/exclude it provides two widgets for better usability.
adc2554
to
0a13fe5
Compare
Jenkins re test this please |
Would be good to get rid of the almost completely useless "~ 94 recipients" text and instead replace this with a URL "Show Recipients" which links to a contact listing of the actual recipients for the mailing based on the criteria. Open in new page - similar to the Mailing report links. Because showing some of the recipients is far less useful than showing the actual recipients. Otherwise, definitely better than the current feature. Thanks! |
@agileware-justin just to keep things focused, please open a different issue for that. This PR doesn't touch that piece. |
No worries |
This works for me. |
Now how will @demeritcowboy get in touch with his old friend Null? |
Ah, clever reference!
Yeah, if only. |
|
Even in APIv4, it lives on! civicrm-core/Civi/Api4/Utils/FormattingUtil.php Lines 56 to 68 in fbdb1ee
|
Overview
When composing a mailing, this replaces the single include/exclude/groups/mailings widget with two widgets, one for include and another for exclude. Groups and mailing are still combined together in autocomplete results, but are loaded more efficiently by APIv4.
Original proposal: https://lab.civicrm.org/dev/core/-/issues/4045
Replaces #26522
Before
After
Technical Details
Builds on #26536 and #26583 to create a SearchDisplay that UNIONS groups and mailings.