Move recurring handling to recur function in PaypalIPN

[eileenmcnaughton]

Overview

Move recurring handling to recur function in PaypalIPN

Before

The code looks like

    if ($this->getContributionRecurID()) {
       - load the recurring contribution
       -- figure out if it is the first contribution
       - call recur with these values
       - send a nofitifcation if applicable
       - return, end processing
    }

   function(recur)  {
   --- do recurring stuff
   }
   

After

    if ($this->getContributionRecurID()) {
         - call recur
          - return, end processing
    }

   function(recur)  {
          - load the recurring contribution
       -- figure out if it is the first contribution
   --- do recurring stuff
       - send a nofitifcation if applicable
   

Technical Details

This builds on earlier cleanup which makes this separation an easy next step

Comments

[civibot]

(Standard links)

• If you are reviewing this pull-request, you may wish to consult the test sites and the Review Standards (long template, short template).

[eileenmcnaughton]

test this please

[seamuslee001]

this seems ok to me