Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Superficial clean up in test class #26559

Merged
merged 1 commit into from
Jun 19, 2023

Conversation

eileenmcnaughton
Copy link
Contributor

Overview

Superficial clean up in test class

Before

Minor bits & pieces like typos, spelling warnings, lack of type hints

After

Cleaner in the IDE - removed a call to a deprecated function

Technical Details

Comments

@civibot
Copy link

civibot bot commented Jun 17, 2023

(Standard links)

@civibot civibot bot added the master label Jun 17, 2023
@@ -240,7 +229,7 @@ public function getPaypalTransaction() {
'payment_status' => 'Completed',
'receiver_email' => 'sunil._1183377782_biz_api1.webaccess.co.in',
'txn_type' => 'web_accept',
'last_name' => 'Roberty',
'last_name' => 'Robert',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This may have been just so it was different from first name, but not a blocker.

Also the _customFieldID declaration at the top of the file can go now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@demeritcowboy yeah - I tend to clean up stuff that needlessly upsets spell checker

@demeritcowboy demeritcowboy merged commit 328581d into civicrm:master Jun 19, 2023
@eileenmcnaughton eileenmcnaughton deleted the paypal branch June 19, 2023 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants