Duplicate the few lines of shared code between completeOrder into repeatTransaction
#26556
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Standard links)
|
…form repeateOrder
eileenmcnaughton
force-pushed
the
repeat_2
branch
from
3a3ab77 to
675f458
Compare
yashodha
referenced
this pull request
in cividesk/civicrm-core
Jun 21, 2023
Get changes from civicrm#10920 with additional changes for recurring payment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Duplicate the few lines of shared code between
completeOrderintorepeatTransactionBuilds on #26555 to get to a situation where
completeOrderis doing no work at all forrepeatTransationBefore
Some shared code before the repeatTransaction early return
After
No shared code - no functionl reason not to call
repeatTransationdirectlyTechnical Details
Comments